weixiuli commented on PR #9026: URL: https://github.com/apache/incubator-gluten/pull/9026#issuecomment-2745107825
> Yes I would support continuing optimising the strategy, though I was curious why we need to have a new rule for the optimisation. Say we can put more code to PartialProjectRule. We may can't add the code directly into PartialProjectRule to avoid ColumnarToRow ? The ColumnarToRow of plan may be inserted by the `InsertTransitions` after the `PartialProjectRule`: https://github.com/apache/incubator-gluten/blob/ee99bf008204296958611966042dfaa8bdda072d/backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxRuleApi.scala#L93-L108 So, we may try to add an new rule like `RemoveTopmostColumnarToRow` after `InsertTransitions`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
