jackylee-ch commented on code in PR #9103:
URL: https://github.com/apache/incubator-gluten/pull/9103#discussion_r2011302814
##########
cpp/velox/compute/VeloxRuntime.cc:
##########
@@ -65,6 +70,14 @@ VeloxRuntime::VeloxRuntime(
debugModeEnabled_ = veloxCfg_->get<bool>(kDebugModeEnabled, false);
FLAGS_minloglevel = veloxCfg_->get<uint32_t>(kGlogSeverityLevel,
FLAGS_minloglevel);
FLAGS_v = veloxCfg_->get<uint32_t>(kGlogVerboseLevel, FLAGS_v);
+ FLAGS_velox_exception_user_stacktrace_enabled =
+ veloxCfg_->get<bool>(kEnableUserExceptionStacktrace,
FLAGS_velox_exception_user_stacktrace_enabled);
Review Comment:
It is the same actually. `SQLConf.get.getALL` would get all user-configured
confs and passed to here, so the default value here is not necessary.
##########
cpp/velox/compute/VeloxBackend.cc:
##########
@@ -113,7 +113,8 @@ void VeloxBackend::init(const
std::unordered_map<std::string, std::string>& conf
google::InitGoogleLogging("gluten");
// Allow growing buffer in another task through its memory pool.
- FLAGS_velox_memory_pool_capacity_transfer_across_tasks = true;
+ FLAGS_velox_memory_pool_capacity_transfer_across_tasks =
+ backendConf_->get<int32_t>(kMemoryPoolCapacityTransferAcrossTasks, true);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
