ArnavBalyan commented on code in PR #9096:
URL: https://github.com/apache/incubator-gluten/pull/9096#discussion_r2011644340
##########
gluten-ut/common/src/test/scala/org/apache/spark/sql/GlutenTestsTrait.scala:
##########
@@ -361,4 +355,20 @@ trait GlutenTestsTrait extends GlutenTestsCommonTrait {
_spark.sparkContext.parallelize(Seq(inputRow)),
StructType(structFileSeq.toSeq))
}
+
+ protected def checkEvaluationWithFallback(
+ expression: => Expression,
+ expected: Any,
+ inputRow: InternalRow = EmptyRow): Unit = {
+ val resolver = ResolveTimeZone
+ val expr = resolver.resolveTimeZones(expression)
+ val catalystValue = CatalystTypeConverters.convertToCatalyst(expected)
+ checkEvaluationWithoutCodegen(expr, catalystValue, inputRow)
Review Comment:
This is the default flow for `checkEvaluation` in Gluten. For Array/Map
other unsupported types where we can't convert to DF, currently all tests
fallback to vanilla Spark's row based evaluation.
This refactor makes it directly accessable to the test, for cases when it
can't be incorporated into canConvertToDataFrame
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
