WangGuangxin commented on code in PR #9058: URL: https://github.com/apache/incubator-gluten/pull/9058#discussion_r2012975088
########## cpp/velox/memory/VeloxColumnarBatch.cc: ########## @@ -147,7 +168,7 @@ std::shared_ptr<VeloxColumnarBatch> VeloxColumnarBatch::select( std::vector<VectorPtr> childVectors; childNames.reserve(columnIndices.size()); childVectors.reserve(columnIndices.size()); - auto vector = getFlattenedRowVector(); + auto vector = getPartialFlattenedRowVector(columnIndices); Review Comment: For the latter, it use `UnsafeRowSerializer`, and internally use `DecodedVector` to decode input row vector, while the `DecodedVector` requires that the input should be flat, constant or dictionary, but don't support lazy vector. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
