zhouyuan commented on code in PR #9153:
URL: https://github.com/apache/incubator-gluten/pull/9153#discussion_r2017526518
##########
backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHBackend.scala:
##########
@@ -175,7 +176,7 @@ object CHBackendSettings extends BackendSettingsApi with
Logging {
fields: Array[StructField],
rootPaths: Seq[String],
properties: Map[String, String],
- serializableHadoopConf: Option[SerializableConfiguration] = None):
ValidationResult = {
+ hadoopConf: Configuration): ValidationResult = {
Review Comment:
The serialize code is added for viewfs support as we need to pass some info
to Velox. Not sure if the new code can be ser/de-ser and passed down.
The code itself is correct, but there is no viewfs related tests in GHA now
so we may need to check this manually
Cc @wangyum @JkSelf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
