shuai-xu commented on PR #8839: URL: https://github.com/apache/incubator-gluten/pull/8839#issuecomment-2765501045
> > Would other Flink experts like to help verifying the functionality of the patch? > > @zhanglistar @liuyongvs @yangxiao0320 @lsyldliu @leonardBang > > Thanks. > > I will find time to go through the PR code too. > > A lot of memoryleaks right now, because not all objects of velox4j is closed (if I understand correctly close method call via jni desctructor). Also performance is poor because converting Flink RowData into RowVector by 1 values - would be better accumulate some batch and convert list of RowData into one RowVector. Do you try the lasteat code? For your example, all operators are executed in native, no need to fall back to java, performance is much better than flink in my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
