zhztheplayer commented on code in PR #9150:
URL: https://github.com/apache/incubator-gluten/pull/9150#discussion_r2020631124
##########
gluten-core/src/main/java/org/apache/gluten/jni/JniWorkspace.java:
##########
@@ -99,10 +85,10 @@ public static void enableDebug(String debugDir) {
}
}
- public static JniWorkspace getDefault() {
+ public static JniWorkspace getDefault(String rootDir) {
Review Comment:
If we have a parameter passing to `getDefault`, we may consider separating
`getDefault` into `intializeDefault` and `getDefault`? Then make sure
`initializeDefault` is only called once from VeloxListenerApi or CHListenerApi.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
