rui-mo commented on code in PR #9195: URL: https://github.com/apache/incubator-gluten/pull/9195#discussion_r2022854072
########## gluten-ut/spark35/src/test/resources/backends-velox/sql-tests/inputs/datetime-parsing-invalid.sql: ########## @@ -2,10 +2,10 @@ -- parsing invalid value with pattern 'y' -- disable since https://github.com/facebookincubator/velox/pull/12694 --- select to_timestamp('294248', 'y'); -- out of year value range [0, 294247] +select to_timestamp('294248', 'y'); -- out of year value range [0, 294247] Review Comment: ``` Expected "[java.lang.ArithmeticException long overflow]", but got "[org.apache.gluten.exception.GlutenException Could not convert Timestamp(9223402809600, 0) to microseconds]" Result did not match for query select to_timestamp('294248', 'y') (GlutenSQLQueryTestSuite.scala:987) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
