ayushi-agarwal commented on code in PR #7611:
URL: https://github.com/apache/incubator-gluten/pull/7611#discussion_r2024133269
##########
backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala:
##########
@@ -1438,4 +1438,37 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
checkGlutenOperatorMatch[FilterExecTransformer](df)
}
}
+
+ test("date_trunc") {
Review Comment:
I had tried setting this and it gives correct results but I was confused
that for a real workload also do we need to set it? Will setting of this config
not be needed if we pass timezone also to this function?
From velox side I see that in call method of this function, timeZone_ comes
out to be a nullptr, but gluten passes spark.sql.session.timeZone to velox as
query config so I am confused as to why it comes to be a nullptr? Could you
please share light on it as I am new to the timestamp part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
