zhouyuan commented on code in PR #9257:
URL: https://github.com/apache/incubator-gluten/pull/9257#discussion_r2034029372
##########
backends-clickhouse/src/main/scala/org/apache/spark/rpc/GlutenDriverEndpoint.scala:
##########
@@ -32,16 +32,14 @@ import java.util.concurrent.atomic.AtomicInteger
* The gluten driver endpoint is responsible for communicating with the
executor. Executor will
* register with the driver when it starts.
*/
-class GlutenDriverEndpoint extends IsolatedRpcEndpoint with Logging {
+class GlutenDriverEndpoint extends IsolatedThreadSafeRpcEndpoint with Logging {
override val rpcEnv: RpcEnv = SparkEnv.get.rpcEnv
protected val totalRegisteredExecutors = new AtomicInteger(0)
private val driverEndpoint: RpcEndpointRef =
rpcEnv.setupEndpoint(GlutenRpcConstants.GLUTEN_DRIVER_ENDPOINT_NAME, this)
- // TODO(yuan): get thread cnt from spark context
- override def threadCount(): Int = 1
Review Comment:
If I recall correctly this piece of code is left to make it compile on
different Spark versions, we did not use the thread count here for real work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
