zhztheplayer commented on code in PR #9274:
URL: https://github.com/apache/incubator-gluten/pull/9274#discussion_r2035247596
##########
backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala:
##########
@@ -148,7 +148,7 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
- testWithSpecifiedSparkVersion("Test array_append function - STRING",
Some("3.4")) {
+ testAtLeastSparkVersion("Test array_append function - STRING", "3.4") {
Review Comment:
If we do this refactor, can we make arguments in
`testWithSpecifiedSparkVersion` non-optional? So users have clearer choice to
use only one API at a time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
