yikf commented on code in PR #9272:
URL: https://github.com/apache/incubator-gluten/pull/9272#discussion_r2038822615
##########
gluten-substrait/src/main/scala/org/apache/spark/sql/execution/GlutenFallbackReporter.scala:
##########
@@ -40,7 +40,7 @@ case class GlutenFallbackReporter(glutenConf: GlutenConfig,
spark: SparkSession)
return plan
}
printFallbackReason(plan)
- if (glutenConf.glutenUiEnabled) {
+ if (GlutenUIUtils.uiEnabled(spark.sparkContext)) {
Review Comment:
this is not enough. `uiEnabled` might be called anywhere, and when it is
called, `sqlConf` might not have been initialized yet, such as during plugin
initialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
