liujiayi771 commented on code in PR #9280:
URL: https://github.com/apache/incubator-gluten/pull/9280#discussion_r2039840626
##########
gluten-substrait/src/main/scala/org/apache/gluten/utils/PullOutProjectHelper.scala:
##########
@@ -137,16 +137,20 @@ trait PullOutProjectHelper {
protected def rewriteAggregateExpression(
ae: AggregateExpression,
expressionMap: mutable.HashMap[Expression, NamedExpression]):
AggregateExpression = {
- val newAggFuncChildren = ae.aggregateFunction.children.map {
- case literal: Literal => literal
- case other => replaceExpressionWithAttribute(other, expressionMap)
+ ae.mode match {
+ case Partial | Complete =>
Review Comment:
I see. Final mode will not pass `needsPreProject`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
