PHILO-HE commented on code in PR #9294:
URL: https://github.com/apache/incubator-gluten/pull/9294#discussion_r2040676558
##########
ep/build-velox/src/setup-centos7.sh:
##########
@@ -110,7 +110,7 @@ function install_snappy {
function install_dwarf {
cd "${DEPENDENCY_DIR}"
wget_and_untar
https://github.com/davea42/libdwarf-code/archive/refs/tags/20210528.tar.gz dwarf
- cd dwarf
+ pushd dwarf
Review Comment:
@zhouyuan, thanks for your comment!
The installation for dwarf succeeds as you noted. But it doesn't go back to
the original directory. Then, dwarf directory will be wrongly used when
executing the build commands for other dependency. This issue was related to
the recent pr #9207 which changes the script to use upstream Velox
`wget_and_untar` function.
This pr has fixed the failure. See
https://github.com/apache/incubator-gluten/actions/runs/14413849930/job/40427128080?pr=9294.
We can merge this pr now if no more comment (please ignore the latest CI
failure since we need some code changes in yml file simply for pr validation
and I have reverted those changes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
