ArnavBalyan commented on PR #8914: URL: https://github.com/apache/incubator-gluten/pull/8914#issuecomment-2800456943
> > removing the check seems to have broken tests. > > I suggest we figure out the reason of the test failures first. We'd make sure the operator outputs exactly the same data no matter it's offloaded or not. Otherwise it's a mismatch. > > What did the broken tests look like? Yes, if we offload with the R2C in between collectLimit and it's child, it changes the number of jobs with Gluten. The operator outputs exactly the same data in both ways. However, the current implementation only supports if the child is columnar to avoid R2C overhead and the failing UTs. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
