PHILO-HE commented on code in PR #9349:
URL: https://github.com/apache/incubator-gluten/pull/9349#discussion_r2048388677
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala:
##########
@@ -181,6 +181,11 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi {
function: ExpressionTransformer,
expr: ArrayFilter): ExpressionTransformer = {
expr.function match {
+ // Transformer for array_compact.
+ case LambdaFunction(function, arguments, _)
+ if function.getClass.getSimpleName.equals("IsNotNull") &&
+ function.children == arguments =>
Review Comment:
Is this check for arguments necessary?
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala:
##########
@@ -181,6 +181,11 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi {
function: ExpressionTransformer,
expr: ArrayFilter): ExpressionTransformer = {
expr.function match {
+ // Transformer for array_compact.
+ case LambdaFunction(function, arguments, _)
+ if function.getClass.getSimpleName.equals("IsNotNull") &&
Review Comment:
Can we simplify it as below?
case LambdaFunction(_: IsNotNull, arguments, _)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
