jinchengchenghh commented on code in PR #9333:
URL: https://github.com/apache/incubator-gluten/pull/9333#discussion_r2048558695
##########
.github/workflows/docker_image.yml:
##########
@@ -126,7 +101,7 @@ jobs:
uses: docker/metadata-action@v5
with:
images: ${{ env.DOCKERHUB_REPO }}
- tags: centos-8-jdk8
+ tags: vcpkg-centos-8
Review Comment:
Looks like the tag is changed, some docker images in docker hub maybe
duplicated. I don't suggest to change the tag, the user may face compatible
issue.
##########
ep/build-velox/src/build_velox.sh:
##########
@@ -128,7 +128,8 @@ function compile {
COMPILE_OPTION="$COMPILE_OPTION -DVELOX_ENABLE_BENCHMARKS=ON"
fi
if [ $ENABLE_GPU == "ON" ]; then
- COMPILE_OPTION="$COMPILE_OPTION -DVELOX_ENABLE_GPU=ON
-DVELOX_ENABLE_CUDF=ON"
+ # the cuda default options are for Centos9 image from Meta
+ COMPILE_OPTION="$COMPILE_OPTION -DVELOX_ENABLE_GPU=ON
-DVELOX_ENABLE_CUDF=ON -DCMAKE_CUDA_ARCHITECTURES=70
-DCMAKE_CUDA_COMPILER=/usr/local/cuda-12.8/bin/nvcc"
Review Comment:
I use the ENV here but without CUDA_COMPILER
https://github.com/apache/incubator-gluten/pull/9333/files#diff-395a263b6f69bd7ef4991face3666e100acdd60e47f4b28e0737adbbf5fb945aR12,is
all the environment CUDA COMPILER this path? Do we need to make it an
environment variable in docker image?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
