zml1206 commented on issue #3030:
URL:
https://github.com/apache/incubator-gluten/issues/3030#issuecomment-2814903257
> 2\. Buffered inputs from Velox's hash-aggregate operator, when aggregate
is distinct aggregate
As far as I know, vanilla spark will add an aggregate to remove duplicates
for the distinct aggregation function, so velox does not need to process
distinct. Should we change the isDistinct of AggregateExpression to false?
For example
```
select count(distinct a) from t
```
SparkPlan
```
HashAggregate(keys=[], functions=[count(distinct a#4)],
output=[count(DISTINCT a)#13L])
- HashAggregate(keys=[], functions=[partial_count(distinct a#4)],
output=[count#17L])
- HashAggregate(keys=[a#4], functions=[], output=[a#4])
- HashAggregate(keys=[a#4], functions=[], output=[a#4])
- LocalTableScan [a#4]
```
@zhztheplayer @FelixYBW
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
