zhztheplayer commented on code in PR #9390:
URL: https://github.com/apache/incubator-gluten/pull/9390#discussion_r2053685514
##########
cpp/velox/memory/VeloxMemoryManager.cc:
##########
@@ -280,6 +280,9 @@ const MemoryUsageStats
VeloxMemoryManager::collectMemoryUsageStats() const {
stats.set_peak(listener_->peakBytes());
stats.mutable_children()->emplace(
"gluten::MemoryAllocator",
collectGlutenAllocatorMemoryUsageStats(listenableAlloc_.get()));
+ stats.mutable_children()->emplace("__sys_spilling__",
collectVeloxMemoryUsageStats(veloxMemoryManager_->spillPool()));
+ stats.mutable_children()->emplace("__sys_caching__",
collectVeloxMemoryUsageStats(veloxMemoryManager_->cachePool()));
+ stats.mutable_children()->emplace("__sys_tracing__",
collectVeloxMemoryUsageStats(veloxMemoryManager_->tracePool()));
Review Comment:
Would you like to post an OOM message with this change?
These global pools interact with Spark overhead memory however the message
mainly shows off-heap usages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
