zhouyuan commented on code in PR #9356:
URL: https://github.com/apache/incubator-gluten/pull/9356#discussion_r2056724401
##########
backends-velox/src-uniffle/main/java/org/apache/spark/shuffle/writer/VeloxUniffleColumnarShuffleWriter.java:
##########
@@ -124,13 +125,11 @@ public VeloxUniffleColumnarShuffleWriter(
RssSparkConfig.RSS_WRITER_BUFFER_SIZE.defaultValue().get());
if ((boolean) sparkConf.get(package$.MODULE$.SHUFFLE_COMPRESS())) {
compressionCodec = GlutenShuffleUtils.getCompressionCodec(sparkConf);
- compressionLevel =
- GlutenShuffleUtils.getCompressionLevel(
- sparkConf,
- compressionCodec,
- GlutenConfig.get().columnarShuffleCodecBackend().getOrElse(() ->
null));
+ compressionLevel = GlutenShuffleUtils.getCompressionLevel(sparkConf,
compressionCodec);
compressionBufferSize =
- GlutenShuffleUtils.getSortEvictBufferSize(sparkConf,
compressionCodec);
+ GlutenShuffleUtils.getCompressionBufferSize(sparkConf,
compressionCodec);
+ diskWriteBufferSize =
+ (int) (long)
sparkConf.get(package$.MODULE$.SHUFFLE_DISK_WRITE_BUFFER_SIZE());
Review Comment:
the code is little diffcult to understand, is it necessary to cast to `long`
and then cast to `int`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
