zhouyuan commented on code in PR #8911:
URL: https://github.com/apache/incubator-gluten/pull/8911#discussion_r2057912493
##########
gluten-substrait/src/main/scala/org/apache/spark/sql/execution/GlutenAutoAdjustStageResourceProfile.scala:
##########
@@ -88,6 +88,11 @@ case class GlutenAutoAdjustStageResourceProfile(glutenConf:
GlutenConfig, spark:
val newExecutorMemory =
new ExecutorResourceRequest(ResourceProfile.MEMORY,
newMemoryAmount.toLong)
executorResource.put(ResourceProfile.MEMORY, newExecutorMemory)
+
+ val newExecutorOffheap =
+ new ExecutorResourceRequest(ResourceProfile.OFFHEAP_MEM,
offheapRequest.get.amount / 10)
Review Comment:
@PHILO-HE
Thanks for improving on this!
just to confirm, I can see the code logic is to reduce the offheap memory
size to 1/10, but on-heap memory size is not increased, is this intended?
Thanks, -yuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
