taiyang-li commented on code in PR #9139:
URL: https://github.com/apache/incubator-gluten/pull/9139#discussion_r2057945236


##########
backends-clickhouse/src/main/java/org/apache/gluten/vectorized/CHNativeBlock.java:
##########
@@ -111,4 +117,14 @@ public ColumnarBatch toColumnarBatch() {
     }
     return new ColumnarBatch(vectors, numRows);
   }
+
+  public static ColumnarBatch slice(ColumnarBatch batch, int offset, int 
limit) {
+    if (limit >= batch.numRows()) {

Review Comment:
   if (offset >=   batch.numRows())  throw exception; 
   limit = min(limit, batch.numRow() - offset); 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org

Reply via email to