Yohahaha commented on code in PR #9418:
URL: https://github.com/apache/incubator-gluten/pull/9418#discussion_r2059940068
##########
backends-velox/src/main/scala/org/apache/gluten/execution/VeloxColumnarToRowExec.scala:
##########
@@ -156,12 +154,8 @@ object VeloxColumnarToRowExec {
val cols = batch.numCols()
val rows = batch.numRows()
- val beforeConvert = System.currentTimeMillis()
val batchHandle =
ColumnarBatches.getNativeHandle(BackendsApiManager.getBackendName, batch)
- var info =
- jniWrapper.nativeColumnarToRowConvert(c2rId, batchHandle, 0)
-
- convertTime += (System.currentTimeMillis() - beforeConvert)
Review Comment:
any reason remove this metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
