PHILO-HE commented on code in PR #9444:
URL: https://github.com/apache/incubator-gluten/pull/9444#discussion_r2063026825
##########
ep/build-velox/src/setup-centos7.sh:
##########
@@ -163,19 +163,17 @@ function install_boost {
function install_protobuf {
cd "${DEPENDENCY_DIR}"
- wget
https://github.com/protocolbuffers/protobuf/releases/download/v21.4/protobuf-all-21.4.tar.gz
- tar -xzf protobuf-all-21.4.tar.gz
- cd protobuf-21.4
+ wget_and_untar
https://github.com/protocolbuffers/protobuf/releases/download/v21.4/protobuf-all-21.4.tar.gz
protobuf
+ cd protobuf
./configure CXXFLAGS="-fPIC" --prefix=/usr/local
make "-j$(nproc)"
$SUDO make install
}
function install_gtest {
cd "${DEPENDENCY_DIR}"
- wget
https://github.com/google/googletest/archive/refs/tags/release-1.12.1.tar.gz
- tar -xzf release-1.12.1.tar.gz
- cd googletest-release-1.12.1
+ wget_and_untar
https://github.com/google/googletest/archive/refs/tags/release-1.12.1.tar.gz
googletest
+ cd googletest
Review Comment:
ditto
##########
ep/build-velox/src/setup-centos7.sh:
##########
@@ -163,19 +163,17 @@ function install_boost {
function install_protobuf {
cd "${DEPENDENCY_DIR}"
- wget
https://github.com/protocolbuffers/protobuf/releases/download/v21.4/protobuf-all-21.4.tar.gz
- tar -xzf protobuf-all-21.4.tar.gz
- cd protobuf-21.4
+ wget_and_untar
https://github.com/protocolbuffers/protobuf/releases/download/v21.4/protobuf-all-21.4.tar.gz
protobuf
+ cd protobuf
Review Comment:
Use ` pushd protobuf`, then add `popd` at the end of this function. Then, we
can avoid wrong directory may be possibly used when executing some other
functions. See https://github.com/apache/incubator-gluten/pull/9294.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
