ArnavBalyan commented on code in PR #9455:
URL: https://github.com/apache/incubator-gluten/pull/9455#discussion_r2063817634
##########
cpp/core/utils/ObjectStore.h:
##########
@@ -70,7 +70,14 @@ class ObjectStore {
return storeId_;
}
- ObjectHandle save(std::shared_ptr<void> obj);
+ template <typename T>
+ ObjectHandle save(std::shared_ptr<T> obj) {
+ const std::lock_guard<std::mutex> lock(mtx_);
+ const std::string_view description = typeid(T).name();
Review Comment:
nit: Would it help to add sizeof(T) along with the name in description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
