jinchengchenghh commented on code in PR #9449:
URL: https://github.com/apache/incubator-gluten/pull/9449#discussion_r2065804698
##########
dev/docker/cudf/Dockerfile:
##########
@@ -12,7 +10,8 @@ ENV PATH=$SPARK_HOME/bin:$PATH
ENV CUDA_ARCHITECTURES=70
WORKDIR /opt/gluten
-RUN ./dev/buildbundle-veloxbe.sh --run_setup_script=ON --build_arrow=ON
--spark_version=3.4 --enable_gpu=ON && \
+RUN bash ./dev/buildbundle-veloxbe.sh --run_setup_script=OFF --build_arrow=ON
--spark_version=3.4 --enable_gpu=ON && \
Review Comment:
The base docker image runs setup_centos.sh in velox, but gluten makes some
change on it, I'm not sure if it can run well.
##########
dev/docker/cudf/Dockerfile:
##########
@@ -12,7 +10,8 @@ ENV PATH=$SPARK_HOME/bin:$PATH
ENV CUDA_ARCHITECTURES=70
WORKDIR /opt/gluten
-RUN ./dev/buildbundle-veloxbe.sh --run_setup_script=ON --build_arrow=ON
--spark_version=3.4 --enable_gpu=ON && \
+RUN bash ./dev/buildbundle-veloxbe.sh --run_setup_script=OFF --build_arrow=ON
--spark_version=3.4 --enable_gpu=ON && \
touch cudf.sql && echo "select o_orderkey from orders order by
o_orderkey;" > cudf.sql
# You can try the data in folder
backends-velox/src/test/resources/tpch-data-parquet
+RUN rm -rf /opt/gluten
Review Comment:
Empty line in the end of file
##########
dev/docker/cudf/Dockerfile:
##########
@@ -12,7 +10,8 @@ ENV PATH=$SPARK_HOME/bin:$PATH
ENV CUDA_ARCHITECTURES=70
WORKDIR /opt/gluten
-RUN ./dev/buildbundle-veloxbe.sh --run_setup_script=ON --build_arrow=ON
--spark_version=3.4 --enable_gpu=ON && \
+RUN bash ./dev/buildbundle-veloxbe.sh --run_setup_script=OFF --build_arrow=ON
--spark_version=3.4 --enable_gpu=ON && \
touch cudf.sql && echo "select o_orderkey from orders order by
o_orderkey;" > cudf.sql
# You can try the data in folder
backends-velox/src/test/resources/tpch-data-parquet
+RUN rm -rf /opt/gluten
Review Comment:
The cudf_build is time-consuming, do we remove the cache?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
