Re: [PR] [GLUTEN-9383][VL][FOLLOWUP] Rethrow original exception when handling memory allocation exception [incubator-gluten]

Tue, 29 Apr 2025 19:14:44 -0700 


wForget commented on code in PR #9461:
URL: https://github.com/apache/incubator-gluten/pull/9461#discussion_r2067741836


##########
cpp/velox/memory/VeloxMemoryManager.cc:
##########
@@ -170,10 +170,10 @@ class ListenableArbitrator : public 
velox::memory::MemoryArbitrator {
     auto neededBytes = velox::bits::roundUp(bytes - reclaimedFreeBytes, 
memoryPoolTransferCapacity_);
     try {
       listener_->allocationChanged(neededBytes);
-    } catch (const std::exception& e) {
+    } catch (const std::exception&) {
       // if allocationChanged failed, we need to free the reclaimed bytes
       listener_->allocationChanged(-reclaimedFreeBytes);
-      throw e;
+      std::rethrow_exception(std::current_exception());

Review Comment:
   just refer to velox code:
   
![image](https://github.com/user-attachments/assets/62a4ed9c-04f7-4e3f-94e6-514d6a1a57a3)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to