ArnavBalyan commented on code in PR #9477:
URL: https://github.com/apache/incubator-gluten/pull/9477#discussion_r2069053844
##########
cpp/core/utils/ObjectStore.h:
##########
@@ -73,15 +83,21 @@ class ObjectStore {
template <typename T>
ObjectHandle save(std::shared_ptr<T> obj) {
const std::lock_guard<std::mutex> lock(mtx_);
- const std::string_view description = typeid(T).name();
+ const std::string_view typeName = typeid(T).name();
+ const size_t size = SafeSizeOf<T>::value;
ResourceHandle handle = store_.insert(std::move(obj));
- aliveObjects_.emplace(handle, description);
+ aliveObjects_.emplace(handle, ObjectDebugInfo{typeName, size});
return toObjHandle(handle);
}
private:
static ResourceMap<ObjectStore*>& stores();
+ struct ObjectDebugInfo {
+ std::string_view typeName;
+ size_t size;
Review Comment:
yes updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
