PHILO-HE commented on code in PR #9396:
URL: https://github.com/apache/incubator-gluten/pull/9396#discussion_r2071793629
##########
cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc:
##########
@@ -245,6 +245,13 @@ bool isSupportedArrayCast(const TypePtr& fromType, const
TypePtr& toType) {
return kAllowedArrayElementKinds.count(fromType->kind()) > 0;
}
+ if (toType->kind() == TypeKind::DOUBLE) {
+ if (fromType->kind() == TypeKind::INTEGER || fromType->kind() ==
TypeKind::BIGINT ||
+ fromType->kind() == TypeKind::SMALLINT || fromType->kind() ==
TypeKind::TINYINT) {
Review Comment:
ditto.
##########
cpp/velox/substrait/SubstraitToVeloxPlanValidator.cc:
##########
@@ -245,6 +245,13 @@ bool isSupportedArrayCast(const TypePtr& fromType, const
TypePtr& toType) {
return kAllowedArrayElementKinds.count(fromType->kind()) > 0;
}
+ if (toType->kind() == TypeKind::DOUBLE) {
Review Comment:
Use `toType->isDouble` for simplicity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
