li-boxuan opened a new pull request, #9506:
URL: https://github.com/apache/incubator-gluten/pull/9506

   ## What changes were proposed in this pull request?
   
   In RasOffload.scala, we discard a plan if the offload doesn't succeed. We do 
this check by `offloaded.fastEquals(rewritten)`. This is not the most efficient 
way, and has false positive discards. For example, in TPC-DS, we have observed 
that q44 & q49 didn't offload `WindowExec` to `WindowExecTransformer` with 
legacy RAS, and the reason is `WindowExecTransformer` is deemed as "equal" to 
its `WindowExec` counterparty.
   
   ## How was this patch tested?
   
   (Please explain how this patch was tested. E.g. unit tests, integration 
tests, manual tests)
   
   
   (If this patch involves UI changes, please attach a screenshot; otherwise, 
remove this)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to