shuai-xu commented on code in PR #9446:
URL: https://github.com/apache/incubator-gluten/pull/9446#discussion_r2074668006
##########
gluten-flink/runtime/src/main/java/org/apache/flink/streaming/runtime/translators/SinkTransformationTranslator.java:
##########
@@ -179,30 +180,32 @@ private void expand() {
if (sink instanceof DiscardingSink) {
RowType outputType = (RowType)
LogicalTypeConverter.toVLType(
((InternalTypeInfo)
transformation.getOutputType()).toLogicalType());
- RowType outType = new RowType(List.of("num"), List.of(new
BigIntType()));
- String plan = Serde.toJson(new TableWriteNode(
- String.valueOf(transformation.getId()),
+ // TODO: this is a constrain of velox
+ RowType ignore = new RowType(List.of("num"), List.of(new
BigIntType()));
Review Comment:
Ignore means the result type is not used in flink, it is set only because
velox need it. Add some comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
