PHILO-HE commented on PR #9513: URL: https://github.com/apache/incubator-gluten/pull/9513#issuecomment-2853430220
> cc @PHILO-HE ScalarFunctionValidateSuite.scala has more than 1700 lines. Perhaps we need to refactor the ScalarFunction test to follow the structure in the document https://github.com/apache/incubator-gluten/blob/main/docs/velox-backend-scalar-function-support.md @dcoliversun, thanks for your proposal! Maybe, we don't need to completely follow the categories in that document. Instead, we can move date functions and/or math functions into new suites, as there are so many functions belonging to these two categories. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
