zhztheplayer commented on code in PR #9559:
URL: https://github.com/apache/incubator-gluten/pull/9559#discussion_r2079218026
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxListenerApi.scala:
##########
@@ -204,9 +204,17 @@ class VeloxListenerApi extends ListenerApi with Logging {
if (StringUtils.isNotBlank(libPath)) { // Path based load. Ignore all
other loadees.
JniLibLoader.loadFromPath(libPath)
} else {
+ if (
+ conf.getBoolean(
+ GlutenConfig.COLUMNAR_CUDF_ENABLED.key,
+ GlutenConfig.COLUMNAR_CUDF_ENABLED.defaultValue.get)
+ ) {
+ loader.load(s"$platformLibDir/${System.mapLibraryName("cudf")}")
+ }
Review Comment:
Does `libvelox.so` need `libcudf.so` when GPU support is enabled? If yes,
loading `libvelox.so` should cause the needed `libcudf.so` to be loaded
automatically, so this code is ideally not deeded?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
