zhztheplayer opened a new issue, #9566:
URL: https://github.com/apache/incubator-gluten/issues/9566

   ### Description
   
   [This 
API](https://github.com/bigo-sg/velox4j/blob/1239b1ea42961cacbe38294a01304f2acc0f10f3/src/main/java/io/github/zhztheplayer/velox4j/plan/PlanNode.java#L26-L28)
 added by `bigo-sg/velox4j` is powerful but breaks the immutability of the plan 
node. We look to replace the practice with one of the two possible options:
   
   1. Refactor gluten-flink's code to avoid the `setSources` calls;
   2. Add immutable `PlanNode#withNewSources` API or a builder-based API or so, 
which internally do copies on the query plan to change the sources.
   
   Either way would be more elegant than the current solution.
   
   ### Gluten version
   
   None


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to