zhztheplayer commented on PR #9545:
URL:
https://github.com/apache/incubator-gluten/pull/9545#issuecomment-2865927151
> BTW, I previously tested the new version of the blocking queue without
calling close() on the Java side, but I didn’t notice any warnings about
resources not being properly closed.
@lgbo-ustc I tried with `ScanTest.java` and there were some logs indicating
unclosed row-vectors if i remove `inRv.close()`.
With `inRv.close()`:
```
Stateful velox plan is -- Project[4][expressions: (a:INTEGER, "a"),
(b:BIGINT, "b"), (c:VARCHAR, "c")] -> a:INTEGER, b:BIGINT, c:VARCHAR
-- Filter[3][expression: greaterthan("a",0)] -> a:INTEGER, b:BIGINT,
c:VARCHAR
-- TableScan[5][ExternalStreamTableHandle] -> a:INTEGER, b:BIGINT,
c:VARCHAR
I20250509 10:55:13.276413 786093 Task.cpp:2307] Terminating task Task - EID
0 with state Finished after running for 0ms
W20250509 10:55:13.276546 786093 ObjectStore.cc:34] Unclosed object [Store
ID: 5, Resource handle ID: 4, Description: N7velox4j13BlockingQueueE] is found
when object store is closing. Velox4J will destroy it automatically but it's
recommended to manually close the object through the Java API CppObject#close()
after use, to minimize peak memory pressure of the application.
```
Without `inRv.close()`:
```
Stateful velox plan is -- Project[4][expressions: (a:INTEGER, "a"),
(b:BIGINT, "b"), (c:VARCHAR, "c")] -> a:INTEGER, b:BIGINT, c:VARCHAR
-- Filter[3][expression: greaterthan("a",0)] -> a:INTEGER, b:BIGINT,
c:VARCHAR
-- TableScan[5][ExternalStreamTableHandle] -> a:INTEGER, b:BIGINT,
c:VARCHAR
I20250509 10:53:14.876610 785757 Task.cpp:2307] Terminating task Task - EID
0 with state Finished after running for 0ms
W20250509 10:53:14.876753 785757 ObjectStore.cc:34] Unclosed object [Store
ID: 5, Resource handle ID: 13, Description: N8facebook5velox10BaseVectorE] is
found when object store is closing. Velox4J will destroy it automatically but
it's recommended to manually close the object through the Java API
CppObject#close() after use, to minimize peak memory pressure of the
application.
W20250509 10:53:14.877210 785757 ObjectStore.cc:34] Unclosed object [Store
ID: 5, Resource handle ID: 10, Description: N8facebook5velox10BaseVectorE] is
found when object store is closing. Velox4J will destroy it automatically but
it's recommended to manually close the object through the Java API
CppObject#close() after use, to minimize peak memory pressure of the
application.
W20250509 10:53:14.877609 785757 ObjectStore.cc:34] Unclosed object [Store
ID: 5, Resource handle ID: 7, Description: N8facebook5velox10BaseVectorE] is
found when object store is closing. Velox4J will destroy it automatically but
it's recommended to manually close the object through the Java API
CppObject#close() after use, to minimize peak memory pressure of the
application.
W20250509 10:53:14.878005 785757 ObjectStore.cc:34] Unclosed object [Store
ID: 5, Resource handle ID: 4, Description: N7velox4j13BlockingQueueE] is found
when object store is closing. Velox4J will destroy it automatically but it's
recommended to manually close the object through the Java API CppObject#close()
after use, to minimize peak memory pressure of the application.
```
Would you like to give it a try as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
