Zouxxyy commented on code in PR #9591:
URL: https://github.com/apache/incubator-gluten/pull/9591#discussion_r2083480254
##########
backends-velox/src/test/scala/org/apache/gluten/execution/VeloxRoughCostModelSuite.scala:
##########
@@ -43,7 +43,6 @@ class VeloxRoughCostModelSuite extends
VeloxWholeStageTransformerSuite {
override protected def sparkConf: SparkConf = super.sparkConf
.set(GlutenConfig.RAS_ENABLED.key, "true")
.set(GlutenConfig.RAS_COST_MODEL.key, "rough")
- .set(GlutenConfig.VANILLA_VECTORIZED_READERS_ENABLED.key, "false")
Review Comment:
Checked, adding this configuration has no effect on the results of the
following cases. Because no matter
enable: FileScan(Vectorized) -> ColumnarToRow
disabled: FileScan(row)
their costs are the same, and have to add the r2c node later, if don't want
fallback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
