lgbo-ustc commented on code in PR #9536:
URL: https://github.com/apache/incubator-gluten/pull/9536#discussion_r2097414172
##########
gluten-flink/planner/src/main/java/org/apache/gluten/rexnode/functions/RexCallModConverter.java:
##########
@@ -14,24 +14,30 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.gluten.rexnode.functions;
+
+package org.apache.gluten.rexnode;
import io.github.zhztheplayer.velox4j.expression.CallTypedExpr;
import io.github.zhztheplayer.velox4j.expression.TypedExpr;
import io.github.zhztheplayer.velox4j.type.Type;
-import java.util.List;
+import org.apache.calcite.rex.RexCall;
+import org.apache.gluten.rexnode.RexConversionContext;
+import org.apache.gluten.rexnode.RexNodeConverter;
-/** Default convertor for velox function. */
-public class DefaultFunctionConverter implements FunctionConverter {
- private final String function;
+import java.util.List;
- public DefaultFunctionConverter(String function) {
- this.function = function;
+ class ModRexCallConverter extends BaseRexCallConverter {
Review Comment:
It's used at present,but forgot to register it in factory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
