zhouyuan commented on code in PR #9685: URL: https://github.com/apache/incubator-gluten/pull/9685#discussion_r2097521434
########## dev/vcpkg/ports/libelf/portfile.cmake: ########## @@ -14,10 +14,22 @@ vcpkg_extract_source_archive( file(DOWNLOAD "https://git.savannah.gnu.org/gitweb/?p=config.git;a=blob_plain;f=config.guess;hb=HEAD"; "${SOURCE_PATH}/config.guess" STATUS status_guess) +list(GET status_guess 0 status_code) +list(GET status_guess 1 status_string) +if(NOT status_code EQUAL 0) Review Comment: we may should skip the download, if local file already exists? The other issues on libelf seems due to downloading some empty config.guess/config.sub -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
