ArnavBalyan commented on PR #9718: URL: https://github.com/apache/incubator-gluten/pull/9718#issuecomment-2897170314
> I also meet this problem, not sure why the CI can pass, please see this discussion in Velox, this problem should be fixed by velox. [facebookincubator/velox#13003 (comment)](https://github.com/facebookincubator/velox/pull/13003#discussion_r2096481849) Thanks! If the upstream patches it, we can remove this flag `-Wno-error=cpp`, would still need to enable geo in Gluten to allow correct linking. It seems currently Gluten `main` is not buildable so included this flag along with the change. Should be harmless either way wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
