Yohahaha commented on code in PR #9721:
URL: https://github.com/apache/incubator-gluten/pull/9721#discussion_r2101466675
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxListenerApi.scala:
##########
@@ -55,6 +56,8 @@ class VeloxListenerApi extends ListenerApi with Logging {
override def onDriverStart(sc: SparkContext, pc: PluginContext): Unit = {
val conf = pc.conf()
+ // Register velox conf
+ VeloxConfig.get
Review Comment:
move this logic to `initialize` method.
##########
gluten-arrow/src/main/java/org/apache/gluten/init/NativeBackendInitializer.java:
##########
@@ -68,13 +69,18 @@ public void initialize(ReservationListener rl,
scala.collection.Map<String, Stri
private void initialize0(ReservationListener rl,
scala.collection.Map<String, String> conf) {
try {
Map<String, String> nativeConfMap =
GlutenConfig.getNativeBackendConf(backendName, conf);
+ this.nativeConfMap = nativeConfMap;
initialize(rl, ConfigUtil.serialize(nativeConfMap));
} catch (Exception e) {
LOG.error("Failed to call native backend's initialize method", e);
throw e;
}
}
+ public Map<String, String> nativeConfMap() {
Review Comment:
seems this new method only visible in test? could we try another way to
verify the config has parsed? line 40 will increase memory footprint.
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxListenerApi.scala:
##########
@@ -127,6 +130,8 @@ class VeloxListenerApi extends ListenerApi with Logging {
override def onExecutorStart(pc: PluginContext): Unit = {
val conf = pc.conf()
+ // Register velox conf
+ VeloxConfig.get
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
