zml1206 commented on code in PR #9720:
URL: https://github.com/apache/incubator-gluten/pull/9720#discussion_r2106409275
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/JoinExecTransformer.scala:
##########
@@ -376,24 +360,8 @@ abstract class BroadcastHashJoinExecTransformerBase(
isNullAwareAntiJoin: Boolean)
extends HashJoinLikeExecTransformer {
- override def output: Seq[Attribute] = {
- joinType match {
- case _: InnerLike =>
- left.output ++ right.output
- case LeftOuter =>
- left.output ++ right.output.map(_.withNullability(true))
- case RightOuter =>
- left.output.map(_.withNullability(true)) ++ right.output
- case FullOuter =>
- (left.output ++ right.output).map(_.withNullability(true))
- case j: ExistenceJoin =>
- left.output :+ j.exists
- case LeftExistence(_) =>
- left.output
- case x =>
- throw new IllegalArgumentException(s"${getClass.getSimpleName} not
take $x as the JoinType")
Review Comment:
It moved to JoinUtils, unable to get the correct join class simple name, can
you help fix it? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
