PHILO-HE commented on code in PR #9778:
URL: https://github.com/apache/incubator-gluten/pull/9778#discussion_r2111317731
##########
gluten-flink/patches/fix-velox4j.patch:
##########
@@ -0,0 +1,49 @@
+diff --git a/pom.xml b/pom.xml
+index b266bce..54e53ac 100644
+--- a/pom.xml
++++ b/pom.xml
+@@ -209,27 +209,6 @@
+ <argLine>${surefire.add-opens.argLine}</argLine>
+ </configuration>
+ </plugin>
+- <plugin>
+- <groupId>org.apache.maven.plugins</groupId>
+- <artifactId>maven-gpg-plugin</artifactId>
+- <version>3.2.7</version>
+- <executions>
+- <execution>
+- <id>sign-artifacts</id>
+- <goals>
+- <goal>sign</goal>
+- </goals>
+- <phase>verify</phase>
+- <configuration>
+- <keyname>B63AD11C6D45C37BFD6379B248804000454F1974</keyname>
+- <gpgArguments>
+- <arg>--pinentry-mode</arg>
+- <arg>loopback</arg>
+- </gpgArguments>
+- </configuration>
+- </execution>
+- </executions>
+- </plugin>
+ <plugin>
+ <groupId>org.sonatype.central</groupId>
+ <artifactId>central-publishing-maven-plugin</artifactId>
+diff --git a/src/main/cpp/main/CMakeLists.txt
b/src/main/cpp/main/CMakeLists.txt
+index ada06f8..7ed80bb 100644
+--- a/src/main/cpp/main/CMakeLists.txt
++++ b/src/main/cpp/main/CMakeLists.txt
+@@ -55,10 +55,12 @@ install(
+ CODE "
+ file(GET_RUNTIME_DEPENDENCIES
+ RESOLVED_DEPENDENCIES_VAR 3rd_deps
++ UNRESOLVED_DEPENDENCIES_VAR unresolved_deps
Review Comment:
Without this change, cmake reports lib gflags, boost_atomic are not
resolved, but they are actually contained in the resolved dependencies list,
i.e., 3rd_deps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org
For additional commands, e-mail: commits-h...@gluten.apache.org
