marin-ma commented on PR #9770: URL: https://github.com/apache/incubator-gluten/pull/9770#issuecomment-2919064917
> > Thanks for the fix. Can we get the `isSort` from ShuffleDependency in `CelebornShuffleManager` and pass it to `CelebornColumnarShuffleWriter`? Like what we do for `ColumnarShuffleWriter` https://github.com/apache/incubator-gluten/blob/main/backends-velox/src/main/scala/org/apache/spark/shuffle/ColumnarShuffleWriter.scala#L42 > > I think **get the `isSort` from ShuffleDependency in `CelebornShuffleManager`** is a good idea, and I find ColumnarShuffleWriter can get the dependency reference by `private val dep = handle.dependency.asInstanceOf[ColumnarShuffleDependency[K, V, V]]` , could we add a local variable `isSort` in ColumnarShuffleWriter ? > > ``` > private val dep = handle.dependency.asInstanceOf[ColumnarShuffleDependency[K, V, V]] > val isSort: Boolean = dep.isSort > ``` @wankunde You're right. Then we can make the change simpler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
