JkSelf commented on code in PR #9733:
URL: https://github.com/apache/incubator-gluten/pull/9733#discussion_r2115034294
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/WriteFilesExecTransformer.scala:
##########
@@ -69,6 +71,83 @@ case class WriteFilesExecTransformer(
val caseInsensitiveOptions: CaseInsensitiveMap[String] =
CaseInsensitiveMap(options)
+ private def preProjectionNeeded(): Boolean = {
+ if (partitionColumns == null || partitionColumns.isEmpty) {
Review Comment:
This change is necessary solely for the Velox backend. We need to implement
a check in BackendSettingsApi.scala to set it as disabled by default and enable
it specifically for VeloxBackendSettings. You can refer this code.
https://github.com/apache/incubator-gluten/blob/main/gluten-substrait/src/main/scala/org/apache/gluten/backendsapi/BackendSettingsApi.scala#L65C7-L65C24
https://github.com/apache/incubator-gluten/blob/main/backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala#L383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
