yuanhang-dev commented on code in PR #9630: URL: https://github.com/apache/incubator-gluten/pull/9630#discussion_r2115364866
########## gluten-flink/ut/src/test/java/org/apache/gluten/streaming/api/operators/GlutenAbstractStreamOperatorTest.java: ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gluten.streaming.api.operators; + +import org.apache.flink.streaming.api.operators.AbstractStreamOperatorTest; +import org.junit.jupiter.api.Disabled; +import org.junit.jupiter.api.Test; + +public class GlutenAbstractStreamOperatorTest extends AbstractStreamOperatorTest { + + @Override + @Test + @Disabled + public void testStateDoesNotInterfere() throws Exception { Review Comment: Regarding the usage of `@Disabled` and `@Test`: You can refer to the official documentation at https://junit.org/junit5/docs/current/user-guide/#writing-tests-disabling. In JUnit 5, these two annotations can be safely used together. `@Disabled` temporarily disables the test, but keeping the `@Test` annotation helps with: 1. Clearly identifying that this is still a test method 2. IDEs can properly recognize and display the test status 3. When enabling in the future, we only need to remove `@Disabled` ``` @Disabled @Test @Override public void testStateDoesNotInterfere() ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
