wForget commented on code in PR #9850:
URL: https://github.com/apache/incubator-gluten/pull/9850#discussion_r2128336539
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/ScanTransformerFactory.scala:
##########
@@ -25,11 +25,17 @@ object ScanTransformerFactory {
def createFileSourceScanTransformer(
scanExec: FileSourceScanExec): FileSourceScanExecTransformerBase = {
+ // Partition filters will be evaluated in driver side, so we can remove
+ // GlutenTaskOnlyExpressions
+ val partitionFilters = scanExec.partitionFilters.filter {
+ case _: GlutenTaskOnlyExpression => false
+ case _ => true
+ }
FileSourceScanExecTransformer(
scanExec.relation,
scanExec.output,
scanExec.requiredSchema,
- scanExec.partitionFilters,
+ partitionFilters,
Review Comment:
> Do you need to consider this issue also for the BatchScanTransformer?
Thanks.
I will try to add a unit test to cover this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
