jinchengchenghh commented on code in PR #9397: URL: https://github.com/apache/incubator-gluten/pull/9397#discussion_r2134919351
########## cpp/velox/compute/iceberg/IcebergWriter.h: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include "compute/iceberg/IcebergFormat.h" +#include "memory/VeloxColumnarBatch.h" +#include "velox/connectors/hive/iceberg/IcebergDataSink.h" + +namespace gluten { + +class IcebergWriter { Review Comment: The API is different, for function commit vs close return type, and initialize arguments, Iceberg datasource needs partition spec, now it does not include in this PR but will be supported later. And VeloxDataSource onlys supports parquet, so it does not have the argument format, and the compressionKind gets from iceberg TableProperty not sparkConfs, so much difference makes it a separate class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
