PHILO-HE commented on code in PR #9908:
URL: https://github.com/apache/incubator-gluten/pull/9908#discussion_r2136747402
##########
backends-velox/src/test/scala/org/apache/gluten/functions/ScalarFunctionsValidateSuite.scala:
##########
@@ -511,6 +511,15 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
+ test("Test map_from_arrays function optimized by Spark constant folding") {
+ withSQLConf(("spark.sql.optimizer.excludedRules",
NullPropagation.ruleName)) {
Review Comment:
It seems this is to override super class's configuration. And
NullPropagation has no impact on this test case. Maybe, we can just set it with
empty string for better readability.
##########
backends-velox/src/test/scala/org/apache/gluten/functions/ScalarFunctionsValidateSuite.scala:
##########
@@ -511,6 +511,15 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
+ test("Test map_from_arrays function optimized by Spark constant folding") {
+ withSQLConf(("spark.sql.optimizer.excludedRules",
NullPropagation.ruleName)) {
+ runQueryAndCompare("""SELECT map_from_arrays(sequence(1, 5),sequence(1,
5)), l_orderkey
+ | from lineitem limit 100""".stripMargin) {
Review Comment:
Nit:
Limit 100 is unnecessarily large for result comparison. Let's decrease it to
a smaller value, e.g., 10.
##########
backends-velox/src/test/scala/org/apache/gluten/functions/ScalarFunctionsValidateSuite.scala:
##########
@@ -511,6 +511,15 @@ abstract class ScalarFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
+ test("Test map_from_arrays function optimized by Spark constant folding") {
Review Comment:
Nit:
Follow the test name style and , e.g., "map_from_arrays optimized by Spark
constant folding"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
