yaooqinn commented on code in PR #9914:
URL: https://github.com/apache/incubator-gluten/pull/9914#discussion_r2139052627
##########
backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHListenerApi.scala:
##########
@@ -102,14 +101,14 @@ class CHListenerApi extends ListenerApi with Logging {
}
// add memory limit for external sort
- if (conf.getLong(RuntimeSettings.MAX_BYTES_BEFORE_EXTERNAL_SORT.key, -1) <
0) {
- if (conf.getBoolean("spark.memory.offHeap.enabled", defaultValue =
false)) {
- val memSize =
JavaUtils.byteStringAsBytes(conf.get("spark.memory.offHeap.size"))
+ if (conf.get(RuntimeSettings.MAX_BYTES_BEFORE_EXTERNAL_SORT) <= 0) {
Review Comment:
This PR is more about refactoring, and we can revisit this part by the
module owners
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
