PHILO-HE commented on code in PR #9799: URL: https://github.com/apache/incubator-gluten/pull/9799#discussion_r2143993546
########## dev/package.sh: ########## @@ -27,7 +27,7 @@ cd "$GLUTEN_DIR" # build gluten with velox backend, prompt always respond y export PROMPT_ALWAYS_RESPOND=y -./dev/buildbundle-veloxbe.sh --enable_vcpkg=OFF --build_tests=ON --build_benchmarks=ON --enable_s3=ON --enable_hdfs=ON "$@" +./dev/buildbundle-veloxbe.sh --enable_vcpkg=OFF --build_tests=ON --build_benchmarks=ON --enable_s3=ON --enable_hdfs=ON build_arrow "$@" Review Comment: Adding `build_arrow` will cause only `build_arrow` command is executed in builddeps-veloxbe.sh. We should remove it. https://github.com/apache/incubator-gluten/blob/main/dev/builddeps-veloxbe.sh#L308 ########## .github/workflows/velox_weekly.yml: ########## @@ -25,21 +25,61 @@ on: env: ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true SETUP: 'bash .github/workflows/util/setup_helper.sh' + INSTALL_PREFIX: /usr/local concurrency: group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }} cancel-in-progress: true jobs: + # action/checkout does not work centos7 anymore, so we checkout on ubuntu firstly and then run in centos 7 docker Review Comment: Remove this comment as not aligning with the new changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
